[Parti-discuss] window icons (almost)

[Antoine Martin]

Nathaniel Smith wrote:
> On Tue, Mar 10, 2009 at 12:33 AM, Antoine Martin <antoine at nagafix.co.uk> wrote:
>>>>                pixbuf = gtk.gdk.pixbuf_new_from_data(data,
>>>> gtk.gdk.COLORSPACE_RGB, True, 8, width, height, rowstride)
>>> Does it help to put 'False' as the 3rd argument instead?
>> OMG... it does!
>>
>> We lose transparency, but I think it's good enough as it is (better than
>> nothing)
>> Will send a patch shortly.
> 
> Transparency is easy... the problem is just that _get_rgb or whatever
> it's called is fetching the pixmap data without transparency (b/c for
> ordinary windows alpha is a waste of space) -- you can tell because it
> passes False as the 3rd argument -- and the two calls have to match.
> Just use True on both sides and transparency will work.
Hah, yes, pretty obvious really!

Except... it doesn't seem to work!
Cumulative patch attached (adds has_alpha flag to _get_rgb)
Looks like the server is not sending the alpha channel??

Antoine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parti-window-icon-support.patch
Type: text/x-patch
Size: 4926 bytes
Desc: not available
URL: <http://lists.partiwm.org/pipermail/parti-discuss/attachments/20090310/09e7ba00/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parti-window-icon-support-transparency.patch
Type: text/x-patch
Size: 2457 bytes
Desc: not available
URL: <http://lists.partiwm.org/pipermail/parti-discuss/attachments/20090310/09e7ba00/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.partiwm.org/pipermail/parti-discuss/attachments/20090310/09e7ba00/attachment.pgp>