[Parti-discuss] [PATCH] plain TCP socket support
Antoine Martin
antoine at nagafix.co.uk
Mon Mar 9 06:22:48 EDT 2009
Hi Nathaniel,
Please consider this patch for merging.
Summary of the changes:
* adds "--no-ipc" option for turning off unix domain socket listener.
* adds "--tcp" option for turning on the TCP listener.
* adds "--tcp-offset" option to change the TCP port number offset
(defaults to 16000)
* adds "--host" option to change the host that the TCP listener will
bind to (defaults to 127.0.0.1)
* adds "--port" option to override the offset/displayNo and specify the
port number directly. (1)
* adds support for "tcp:[portNumber]" syntax for the client.
Which will connect to a TCP socket. (using the switches above)
* splits the constructor for XpraServer into 4 methods: init_wm,
init_socket_tcp, init_socket_ipc, init_keymap
(it is a bit more readable this way)
* _new_connection now takes the listener as a parameter (as there may be
2 listeners active)
* updates to the documentation.
(1) I know you were not keen on supporting the "--port" option, but
after some testing with a bunch of scripts I find it difficult not to
require it, ie: scripts that stop and start xpra sessions should not
make any assumptions about the offset/port numbers used, they may locate
the server using the tcp socket only (lsof). It is much nicer to allow
the client to connect to a fixed address (port+host) rather than have to
resort to computations using display numbers and offset that the shell
script should have no knowledge of...
Thanks
Antoine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parti-tcp-socket.patch
Type: text/x-patch
Size: 7642 bytes
Desc: not available
URL: <http://lists.partiwm.org/pipermail/parti-discuss/attachments/20090309/4f20176a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.partiwm.org/pipermail/parti-discuss/attachments/20090309/4f20176a/attachment.pgp>
More information about the Parti-discuss
mailing list